mirror of
https://github.com/praktimarc/kst4contest.git
synced 2026-10-18 21:34:03 +02:00
Rsclub2_2andClaude Opus 5.5
e1e6fe7297
* test: restore the frequency-context and Band.fromPrefix tests (#105) The test file MessageBusManagementThreadFrequencyContextTest sat under src/main, fully commented out, and was deleted with #62 without ever having run. Its two concerns come back as real tests: the bare three-digit context rule of hasExplicitBareFrequencyContext in the controller test package, and Band.fromPrefix as BandFromPrefixTest in the model package. The original expectations still match the current behaviour; a few boundary cases (context window, invalid indices, non-exact prefixes) are added. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test: characterise the autoanswer path of MessageBusManagementThread (#105) Runs real CH frames through a started thread (receive queue plus poison pill, real transmit queue, mocked controller collaborators, a real ChatPreferences in a temporary directory) and pins the current behaviour of the private-message branch before it is refactored: - a QRG question addressed to the login callsign yields exactly one reply with the fixed marker and the QRG of the incoming category; - a second question from the same station and category within the cooldown yields none, while another station or category is answered; - a frame carrying the autoanswer marker, a public frame, a frame to another station and a disabled setting yield none; - an empty QRG and a blank generic text are rejected before the cooldown is recorded, so a later valid reply still goes out; - //VER, the generic reply and its precedence below the QRG reply. One oddity is pinned, not fixed: a lower-case login callsign defeats the "directed to me" comparison because the receiver callsign is upper-cased by ChatMember.setCallSign but compared with equals. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * refactor: extract the autoanswer decisions into pure functions (#105) The QRG-question texts become a constant set; matchesQrgQuestion, isAutoMessage and buildAutoAnswerMessageText are static package-private functions with explicit parameters instead of reaching into the preferences, and the cooldown reads an injectable millisecond clock (default System::currentTimeMillis) through a new constructor overload. Behaviour is unchanged: the characterisation test from the previous commit passes untouched, the new decision and cooldown tests cover the extracted functions without mocks. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * refactor: extract frequency detection into a pure function (#105) smartFrequencyExtraction now copies the sender's band timestamps, reads the fallback prefix and the injectable clock, and hands the text to the static package-private detectFrequencies, which returns the detections in message order as DetectedChatFrequency records. The thread still stores each one through applyDetectedFrequencyToActiveMembers and logs it as before. Behaviour is unchanged. In production the stored detection lands in the same map the next match of the message reads, so detectFrequencies feeds every detection back as context with the current time; a test pins that "10368.100 then .150" yields 10368.150. The unreachable NumberFormatException catches around parseExplicitFrequency are gone, since that parser already returns null instead of throwing. Also pinned: a plain decimal between 50 and 54 (e.g. "qrb 52,3 km") is read as a 6 m frequency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor: extract the directional-opportunity and spot decisions (#105) classifyDirectionalOpportunity returns MISSING_LOCATOR, IN_ANGLE_AND_RANGE or OUT_OF_ANGLE_OR_RANGE from the locators, the maximum QRB and the beam width, and replaces the identical locator check plus isInAngleAndRange call in both the live (CH) and the history (CR) branch. shouldPlayDirectionalTick, decideDxClusterSpot (NO_FREQUENCY, ALREADY_WORKED, SPOT) and buildDxClusterSpotEntry take over the tick condition and the automatic DX Cluster spot of the CH branch. All are static package-private and covered without mocks. Behaviour is unchanged. Pinned: the spot decision only checks that the frequency text is non-blank, so a value outside every supported band is spotted even for a station flagged as worked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor: remove dead code from MessageBusManagementThread (#105) processRXMessage23000 belonged to the long-retired raw port-23000 interface and had no caller. With it go the two helpers only it reached, checkIfItsUserListEntry and checkIfMessageInhibitsFrequency, plus the caller-less checkIfItsUserListEntry23001 and checkListForChatMemberIndexByCallSign, the patterns PTRN_USERLISTENTRY, PTRN_QRG_CAT2 and PTRN_QRG_CAT3, the unused chatMemberTable field and the serverReady flag with its never-called accessors. A grep across core and app-desktop finds no remaining reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor: keep the sender-category fallback in the QRG auto-answer warning (#105) Review follow-up. The extracted buildAutoAnswerMessageText logged only the message category, while the old warning used autoAnswerCooldownKey, which falls back to the sender's category. The caller now passes the same fallback, so the log line is unchanged from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
KST4Contest
KST4Contest is a Java-based client for the ON4KST chat, developed for coordinated VHF, UHF and microwave contest operation.
The application is developed by Marc Fröhlich (DO5AMF) and since 2026 Philipp Wagner (DN9APW).
Start here
- Project website
- Download Stable, Beta and Nightly builds
- Online manual
- GitHub wiki
- Issues and bug reports
- Development roadmap
What KST4Contest does
KST4Contest combines the ON4KST chat with information that is useful when coordinating contacts during a contest.
Among other things, it can:
- display and filter stations from the supported ON4KST chat categories;
- derive band and frequency information from chat messages and station names;
- maintain Worked and NOT QRV information for the available bands;
- calculate station priorities from distance, activity and other available information;
- manage internal skeds and received Win-Test skeds;
- use AirScout information when evaluating possible aircraft-scatter contacts;
- display stations, paths and additional propagation information on maps;
- exchange information with supported logging programs, Win-Test, PSTRotator and a local DX Cluster interface;
- provide configurable automatic replies for recurring chat requests.
Calculated scores, aircraft-scatter information and path assessments are operating aids. They depend on the available data and should not be treated as guarantees that a contact is possible.
Installation
Ready-to-use packages are available for Windows, Linux and macOS. These packages include the required Java runtime, so a separate Java installation is normally not necessary.
Use the central download page to select the appropriate build:
- Stable is intended for normal contest operation.
- Beta contains changes that are being prepared for a stable release.
- Nightly contains the latest automated development build and is mainly intended for testing.
Documentation
The documentation is available in German and English:
The Markdown sources used for the wiki and the generated PDF manuals are stored in github_docs.
Changes to operating behaviour should be documented together with their purpose and limitations. This is especially important for functions whose result depends on external data, heuristics or information derived from chat messages.
Building from source
Building KST4Contest requires JDK 21. The Gradle Wrapper included in the repository should be used, so a separate Gradle installation is not required.
Linux and macOS:
./gradlew clean build
Windows:
.\gradlew.bat clean build
Repository structure
core/– domain, controller and network code, free of user-interface technologyapp-desktop/– the Compose Multiplatform user interface and the packaging tasksgithub_docs/– German and English manual sourceswebsite/– project website sourcespackaging/– platform-specific packaging files
CI status
Documentation
Builds
License
KST4Contest is distributed under the GNU General Public License v3.0.
Supporters/Sponsor
This Project is possible due to donations of the community.
You can sponsor KST4Contest here: Support on Ko-Fi. If you add an Display Name there you will be mentioned here.
The following people are sponsoring KST4Contest:
- Marco (DJ5KW)