Rsclub2_2/kst4contest
1
0 Fork 0
mirror of https://github.com/praktimarc/kst4contest.git synced 2026-10-19 05:42:58 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
89d37e62e1d82c9f146778336ed5bd35aa539c9c
kst4contest/docs/CONCEPT_IN_APP_UPDATE.md
T
Rsclub2_2andClaude Opus 5.5 2a5c89b943 Next major release/version1.50 (#89) 
* Make DBController work on one database file per instance

The controller was a static singleton: an eagerly created static instance
opened the root database during class initialization, and both the connection
and the path were static fields. A second operator profile in the same process
was therefore impossible, and ChatController's own "new DBController()" never
opened anything - it silently adopted the eagerly opened root connection.

- drop the eager static instance in favour of a lazily created default instance
- turn connection and path into instance state
- add a constructor taking a database file name relative to the application
  directory plus a flag whether a missing file is seeded from the bundled
  template
- create additional profile databases empty instead of seeding them: the
  bundled template carries 3452 foreign callsigns and user_version 0, which
  would show a new operator foreign data and trigger the full callsign
  normalization rebuild. The schema is created by the existing table setup.
- remember the shutdown hook so closeDBConnection can deregister it; otherwise
  every profile switch would leave another hook holding a dead connection

All SQL statements keep referencing the plain field and are unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Allow preferences and chat controller to be bound to a file set

ChatPreferences gains a constructor taking a preferences file name relative to
the application directory, so "profiles/OP2/preferences.xml" is as valid as the
historic flat "preferences.xml". A missing file is still seeded from the
bundled template, which gives an additional operator the same clean defaults a
first installation gets.

ChatController gains a constructor that passes both relative file names and the
seed flag through to ChatPreferences and DBController. The existing
constructors delegate to the historic file names, so nothing changes yet.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Introduce the operator profile model and its registry

Adds the descriptor, the path derivation and the registry persistence for
operator profiles. Nothing calls them yet, so behaviour is unchanged.

The descriptor stores only a shared/own flag, never a path. All file names are
derived in OperatorProfilePaths, so a stored path can never drift apart from
the flag that produced it. A profile identifier is a stable, file system safe
slug assigned once, so renaming a profile never moves a directory.

The registry is created lazily. An installation that only has the historic flat
layout gets no registry file and no profiles directory; the root profile is
synthesised in memory instead. That keeps a single operator installation
byte for byte the one it was before, and it keeps a downgrade to an older
release a no-op. A missing, unreadable or malformed registry is logged and
treated like an installation without additional profiles, never as an error.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Select the operator profile at startup

Resolves the active operator profile before the chat controller is built and
passes its two file names on, so preferences, layout and worked data follow the
profile.

The resolution is deliberately quiet for existing installations. With no
registry or exactly one profile nothing is asked and nothing is written, so a
single operator start is unchanged. Only from two profiles on does a small
picker appear with the last used profile preselected, where Enter or a double
click starts immediately. A "--profile" argument, or the equivalent system
property, skips the picker; an unknown name warns and falls back to the normal
selection instead of refusing to start.

The startup decision itself lives in OperatorProfileBootstrap and contains no
user interface code, so it is covered by headless tests. The window title gains
the profile name only when a second profile exists.

Command line parsing happens in init() and is kept in a process wide holder,
because JavaFX only knows the parameters of the instance it launched itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Release the background resources a discarded runtime owns

Several resources outlived a disconnect on purpose, which was harmless while a
process ran exactly one session for its whole life. They are now released when
the controller itself is closed:

- the ON4KST connection supervisor thread, which stopByUser did not touch
- the sked reminder scheduler, which had no shutdown at all
- the reachability executor, whose shutdown method existed but was never called
- the PSTRotator retry scheduler and its pending retry
- the map tile proxy, whose stop method existed but was never called, leaving a
  server socket and a twelve thread pool behind
- the station map bridge listeners and its coalescing animation, which would
  otherwise keep firing into a dead user interface

These are real leaks today; they only become visible when a second runtime is
built in the same process.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Switch the operator profile while the application is running

Splits the teardown out of stop() into a reusable, idempotent shutdownRuntime()
and adds File - Switch operator profile..., which tears the current runtime
down and builds a fresh one for the selected profile.

The new runtime is a new application instance rather than a second start() on
the existing one. Many controls are instance fields created once, so reusing
the instance would re-parent mounted nodes and register every listener twice.
A fresh instance is safe because the class keeps no mutable static state.

Closing every window during a switch would end the process under the JavaFX
default, so the application takes over the exit decision: implicit exit is
turned off, the main window gets an explicit close handler, and every exit path
runs through the launcher. That also fixes losing the window layout on exit
after a switch, because JavaFX only calls stop() on the instance it launched.

The two view timers are now cancelled null-safe; stop() used to dereference
them unguarded, which would fail if shutdown happened before they were created.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Manage operator profiles from the settings window

Adds a "Profiles" tab, appended last so no established tab position shifts,
offering create, duplicate, rename, delete, a switch between shared and own
worked stations, and activation of another profile.

Duplicating copies the whole configuration except callsign and password. The
antenna, locator, layout and integration settings are exactly the work nobody
wants to enter twice, while the credentials belong to one operator only. The
root profile can neither be deleted nor moved off the common station database,
because its files are the installation itself.

The login callsign and its raw form now default to empty instead of a real
callsign. The XML reader treats an empty element as "not set" and falls back to
the field default, so without this change a profile created without credentials
would come up carrying the callsign compiled into the defaults - and an
operator could transmit under someone else's call.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Document operator profiles

Adds a manual section in both languages covering where profile files live, the
choice between shared and own worked stations, managing profiles, the startup
selection and the --profile argument, switching while running, and the fact
that passwords stay in clear text so profiles are not an access boundary.

Records the architecture in PROJECT_CONTEXT: lazy registry, derived paths, why
an additional profile database is created empty, why the login callsign default
is empty, and the constraints of rebuilding the runtime for a switch.

Adds a v1.50 changelog entry in both languages including the upgrade notes: no
file is moved, and going back to an older release stays possible.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Make the terrain profile cache multi operator safe

The cache stored a single owner identity in a meta table and dropped the whole
TerrainProfileCache table whenever the configured callsign or locator differed
from it. With several operator profiles that turns the cache into a permanent
miss: every switch between two operators with different locators would discard
every computed profile.

Entries are separated by owner identity through the primary key already, so the
wipe is replaced by an owner table that simply records which identities are in
use. A different owner now misses the cache instead of clearing everybody's.

The cache also moves out of the worked station database into its own global
terrainprofilecache.db. Terrain profiles are pure geometry derived from two
locators and a sample count; at a multi operator station both operators share
one location, so a per profile copy would only double the traffic against the
terrain service. No migration is needed, the new file refills itself, and the
old tables stay readable for older releases.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Fail cleanly when the registry path has no directory

SpotBugs flagged a null passed to Files.createTempFile: the null check guarded
only createDirectories, while the temporary file creation would still have
dereferenced it. The path is resolved absolute so this is practically
unreachable, but bailing out with a log line is cheaper than the latent NPE.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm

* Code Version 1.50

* Add the in-app update concept for 1.50

Captures the agreed design so it can be handed over later: extended
update feed with per-artifact metadata, a build-time package-type
marker, a testable check service replacing the blocking call in the
ChatController constructor, a non-modal hint suppressed while connected
to ON4KST, verified downloads and platform-specific execution.

Concept only, nothing implemented yet. Line anchors were verified
against this branch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HT8R7zTMoQnmJj6dGbaqqf

* Use one base font size and a per-profile startup design

JavaFX picks a 13px default font on macOS and Linux but 12px on
Windows, so labels in fixed-size controls were cut off outside
Windows. Both stylesheets now set 12px on the root.

Each operator profile now chooses light or dark mode for startup on
the GUI settings tab. The Windows menu entries remain a quick switch
for the running session. All windows, including the update window
and the top candidates list, follow the design, and the main window
no longer starts light while the station map starts dark.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Show a drag-to-install layout in the macOS DMG

The DMG window now has a background with an arrow from the app to
the Applications folder, in the KST4Contest colours. Finder applies
the layout through AppleScript; if that fails, e.g. on a headless
runner, the script warns and builds the plain DMG as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Use the macOS system menu bar in all windows

On macOS the main menus move into the system menu bar and are shared
with the secondary windows, so they stay available whichever window
has the focus. The connection state indicator becomes a read-only
LINK menu there instead of the status bar button. Other platforms
are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* List direct commits on main in the release notes

GitHub's generated release notes only cover merged pull requests, so
commits pushed straight to main were missing. The release job now
builds the notes itself: "What's Changed" holds "Commits on main"
(first-parent, without bot and squash-merge commits) and GitHub's PR
list as "Merged PRs".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Build with Gradle in two modules, and free core of JavaFX

Etappen 1 and 2 of the Compose migration (43 commits).

The Maven build, the single source tree and the JPMS module-info went together.
core now holds the domain and app-desktop the user interface, both built by
Gradle, packaged through jpackage from Gradle, with SpotBugs and PMD wired in.
JavaFX moves to the classpath, which is why the launcher is Main and not the
Application subclass. The PR check, the nightly artifacts, the release and the
AUR packages all build from Gradle; the macOS DMG points at its output.
Verified on Linux, macOS and Windows.

core then loses JavaFX entirely. It observes through kst4contest.observe --
ObservableValue, ObservableRoster, and UiDispatcher as the one boundary a
worker thread crosses to touch the interface. The controller collections become
rosters and the visible station list a pure derivation rather than a
FilteredList/SortedList chain, which is also what fixed two focus defects only
a load test had exposed: the keyboard focus stays where the operator put it,
and the send field keeps it after a row click.

The rule that outlives this commit: ObservableRoster is the store and the list
a view is bound to is a mirror of it, never the other way round.

* Draw the whole interface in Compose

Etappen 3 to 6a of the migration (129 commits). Every window the operator sees
is Compose; the JavaFX ones still exist beside them so the two could be
compared against a live session, which is the only way the differences came to
light.

The toolchain first, then the settings window with its eleven tabs and 72 real
preferences; then the multi-column table as a component, and with it the rules
it needs -- stable row identity, a selection that survives a refresh, column
order the operator can drag, and a repaint when the rows change rather than
when the list instance does. Then the update and monitor windows, and the main
window: 22 station columns, the filter bar, the selected-station panel, the
message tabs, the priority bar, the sked controls, the status indicators and
the timeline, assembled behind a splitter because Compose has none.

The map stops being a WebView. A Compose canvas projects WebMercator tiles
itself, with the clustering in core and an asynchronous fetcher in place of the
local tile proxy; derive() becomes a pure Kotlin reimplementation instead of a
reflection call into com.sun.javafx.

Most of the volume here is parity the operator would notice rather than new
behaviour: desktop density instead of Material's phone minimums, colours taken
from the JavaFX stylesheets instead of Material's palette, row dividers, band
columns, grid-square labels and their colours, the home marker and antenna
beam, pinch-to-zoom under Wayland, and layouts that survive a window narrower
than the chart they stack.

Two lessons are worth more than the diff. A control bound to a value Compose
cannot observe writes through and never redraws -- that one shipped repeatedly
with a green build, because no test drew anything. And a layout that clips
instead of wrapping is worse than one that is merely too narrow: half a word
is the worst available outcome.

* Remove JavaFX

The second half of Etappe 6 (61 commits). grep -rl "javafx\." over both main
source trees is empty, nothing imports javafx, neither classpath resolves it,
and org.openjfx is out of the build and the version catalog.

The finding that shaped the work: the JavaFX main window was built on every
start and never shown -- primaryStage's setScene and show were both commented
out. Most of those 11,655 lines were dead weight rather than a port. But not
all of them, and that is the trap this commit is really about: dead-looking
methods still fed live Compose sinks. They were cut at their seams instead of
deleted, and a sweep script that follows calls was written to find them,
because reading the code does not reveal them.

In order: the colour derivation frozen as checked-in test data, so the pin
survives JavaFX being removed instead of silently comparing against itself;
the live feeds lifted out of the never-shown window and given names and tests;
the dead scaffolding deleted in slices; then the lifecycle. UiDispatcher now
delivers to the AWT event dispatch thread, the ten Alerts are modal Compose
dialogs, HostServices gives way to java.awt.Desktop with the mailto/http split
JavaFX did not need, and extends Application, start(Stage), stop and launch are
gone -- main builds the runtime and a shutdown hook replaces stop().

An independent review found two deadlocks in that move, both the same failure
class, both invisible to the build: a blocking wait on the event thread for
work that can only advance on the event thread. The profile picker waited on a
latch and froze the client for good; ComposeWindowHost.close waited on
Thread.join and returned with the window still marked open, which made a
profile switch raise the dead runtime's window and leave the rebuilt profile
without its Connect button. A third came out of fixing them: a ComposeDialog
built off the event thread cannot create its GL context and never paints.

Three defects only a GUI run showed, never the build: an NPE on a deleted
field, a Compose menu still hanging on deleted MenuItems, and a category
bookkeeping field that looked dead but is read by the outgoing-message category
resolution -- deleting it would have sent messages in the wrong category.

The binding docs and the manual no longer describe a JavaFX client.

* Draw the menu bar in Compose, and give the drawing layer a net

What the removal left open (4 commits).

Compose's MenuBar is a javax.swing.JMenuBar set on the window, so Swing draws
it and no theme reaches it; with no look-and-feel configured that meant the
default Metal menu above a themed window. The bar is drawn in the window now,
except on macOS, where the system bar is where that platform expects it. Two
renderers read one description -- mainMenuModel is a plain function of the
state, which also gives the menus their first tests. Closing the main window
quits the application again, and the window writes its size back to the
profile; both had quietly stopped working when the last JavaFX stage went.

Then Etappe 7. Four faults shipped in the settings-window branch alongside a
green suite of 382 tests, because not one of those tests drew anything: a
control that never redrew, a tab strip that clipped mid-word, a form taller
than its window with no way down, and colours that came from Material rather
than the stylesheet. One regression test per class, and the spec's acceptance
criterion is met rather than assumed -- each fault was put back deliberately
and the matching test watched to fail.

The CI had never run the suite at all; it does now, headless. What that took
was not Xvfb: skiko's native library links against libGL and only has to be
loadable, since the drawing tests render in software. Without the package the
whole Compose half of the suite dies with a message that reads like a missing
display. Found by running the job under act rather than on GitHub.

The six tests that open a real window skip headless by their own guard. The
summary step counts from the result XML and fails on failures there, because
this project's rule is never to infer a green suite from an exit code.

* Make the colours adjustable per operator profile

Six colour roles per design, per profile: surface, window surface, field interior,
text, accent and separator line. A change applies at once in every open window and
survives a restart once the settings are saved, like any other preference.

Three sources, later wins role by role: the shipped stylesheet from the classpath,
then the profile's own stylesheet file if there is one, then the overrides stored in
the profile's preferences. resolvePalette is a pure function and reports where every
role's colour came from, which the tab shows per field -- with two sources able to
decide one colour, that is the only thing keeping "why is this colour what it is"
answerable, and the spec calls it mandatory rather than decorative.

Four things this had to get right, each learned the hard way and each pinned:

A role is a selector and a property, not a property alone. Three of the six are
stated outside .root -- text on .label, the separator on .separator *.line -- and
-fx-background-color alone appears a dozen times in the evening sheet. Measured: the
shipped daylight sheet states no colour at all, the evening sheet states five and
implies the sixth.

Kst4ContestTheme reads the palette from the store's state and not from remember.
That read is what makes a change repaint every open window; remember(darkMode) held
the palette until somebody toggled day/evening, so a change reached nothing.

A derived colour follows its source's value, never its provenance. The root
profile's own stylesheet is the one copyResourceIfRequired writes at every startup --
the shipped sheet itself -- so layer 2 declares the accent on every existing
installation with nobody having chosen anything. Keying textAccent on "does this come
from a file" repainted the evening accent from green to blue on upgrade and made
"reset to shipped" disagree with "discard my changes".

The contrast guard measures where colours are actually drawn, read off Theme.kt's
Material mapping rather than off the role names: background and surface are both the
window surface, and primary is textAccent, not accent. It reports a pair only when it
is both under WCAG AA and worse than the shipped sheet -- the shipped sheets have
three pairs under 4.5 themselves, so an absolute floor would warn on an untouched
client and teach the operator to ignore warnings.

The way back out of an unreadable palette is deliberately overbuilt, because it is
the one failure that locks itself in. "Reset to the shipped colours" takes the
shipped palette as a required parameter and reads no composition local, so there is
no path by which it could be drawn in the colours it exists to undo; it looks out of
place under a customised palette, and that is what makes it findable. Ctrl+Z, Ctrl+D
and Ctrl+R reach the three ways back even with the caret in a colour field. A
mistyped colour is refused and the field snaps back.

The profile's stylesheet is the hand-editing route the copy under ~/.praktiKST has
been promising since it was first written and never read. It is read now. A button
writes the shipped template as a starting point and never replaces a file that is
already there. An unreadable, truncated or non-CSS file does not prevent startup --
the role falls back to the shipped design. A sheet stating -fx-base and no
-fx-background states the derived window surface too, the way JavaFX does, or the
most natural hand edit would leave every window the shipped light grey.

101 new tests. All of it runs headless.

* Document the adjustable colours, and record the design and the plan

Both manuals get the Colours tab in full: the six roles, that a change applies at
once but survives a restart only after Save settings, the three ways back with their
keyboard shortcuts, what each provenance label means, and the readability notice that
warns without refusing.

Two things an operator would otherwise have to discover. The reset button is always
drawn in the shipped colours and works when nothing else can be read -- the risk
section of the design says plainly that a keyboard path only helps whoever knows it,
so the manual is where this has to be written down. And the root profile already has
both stylesheet files, because KST4Contest has been writing them at startup for
years, so most of its roles report "from file" rather than "shipped" with identical
values.

PROJECT_CONTEXT.md records the decisions that outlive this stage: the three sources
and their precedence, that a role is a selector and a property, that the theme must
read the store's state rather than remember, where the contrast pairs come from, why
the root profile's file layer always exists, and why the lifeline refuses the active
palette. Also corrects its claim that CSS stays global -- a profile now owns its
stylesheets.

The design document and the implementation plan are kept as they were written,
including the plan's own corrections where measuring the code contradicted it.

* Speak the operator's language

The interface is German or English, chosen per operator profile on the GUI tab, in force at
once in every open window, and remembered across restarts. 376 texts in both languages.

The texts are ordinary .properties files that nobody has to compile: a contributor copies the
English one, translates the values, and opens a pull request. A third module -- build tooling
that never ships -- turns them into Kotlin before anything compiles, which is what makes a
mistyped key and a wrong argument count compile errors rather than things an operator
discovers. It lives in the main build rather than buildSrc because buildSrc's tests do not run
on `./gradlew build`, measured, and a generator whose tests never run is the exact failure it
exists to prevent.

Incompleteness is allowed and incorrectness is not. A missing key warns and falls back to
English, so a partial contributed language can be submitted at all; an orphan key, a
placeholder the translation drops, a duplicate key or an unreadable file fail the build with
the generator's own message naming the file. The argument count always comes from the English
base. German is held complete by a test because it ships; a contributed language is not.

What is deliberately not translated is the harder half. Protocol frames and chat commands
would break the connection or go unread; the beacon texts, auto answers, snippets and
shortcuts go to other radio amateurs and sit in every operator's stored profile; the 273
println calls in core are diagnostics, and a German stack trace is worse for whoever reads the
bug report; and QRA, QRG, QTF, LOS, Fresnel and wkd read the same in either language. Three
tests guard the boundary by measuring behaviour rather than text: the protocol frames built
under three locales, every preference default compared by reflection, and no translation value
being a protocol command. The reflective one is the only one that covers what nobody thought
of.

One insight turned up three times. Anything built outside a composition freezes the language it
was built in: the window title, the settings tab strip and every column header are all
constructed once at startup -- the columns from Java -- so each now holds a function read when
it is drawn. That also fixed something older and unrelated to language: the main window's title
was a fixed "KST4Contest (Compose)" for the whole session, where the JavaFX window had carried
the live connection line. It carries it again.

A column's id is never translated. It is what the remembered widths and order are keyed on.

* Document the two languages, and how to contribute a third

Both manuals get the language picker in full: where it sits, that it applies per profile and
takes effect at once in every open window, and -- at more length -- what is deliberately left
alone and why. An operator who sees an English beacon text in a German client should be able
to read that it is meant that way.

The contribution route is written down in both, because plain text files are only useful if
somebody knows they are there: copy, translate, submit; a partial file is welcome; the build
reports mistakes by file name and writes a worksheet of what is still missing.

PROJECT_CONTEXT records the decisions that outlive this stage -- the four kinds of text and
the rule that the addressee decides, that core produces no display text, that incompleteness
is allowed and incorrectness is not, that anything built outside a composition needs its text
read inside one, and that a column id is never translated.

CLAUDE.md said two modules; there are three, and the third never ships. It also states the
German orthography now, which this session got wrong across a spec and two plans: ss after a
short vowel, so muss and dass.

* Remove the implementation plans now that every stage is executed

Thirteen plans, all of them step-by-step instructions for work that is committed. A plan left
behind reads to the next person like an open intention, and these describe a build that no
longer exists -- the first still explains how to introduce Gradle.

The specifications stay. They say why the architecture is what it is, which the code cannot,
and three of them are still argued from. The live-findings note stays too: CLAUDE.md sends
people to it, and its hardest lesson -- that a blocking wait on the AWT event thread deadlocks
the interface while the build stays green -- is written down nowhere else.

Its sweep script stays as well. The note argues explicitly that the script belongs beside the
finding so the next reader can measure rather than believe, and removing it would contradict
the reasoning it illustrates.

Two references in the note and one in the JavaFX-removal spec pointed at plans and now say
where the reasoning went instead.

* Point the JavaFX-removal spec at where its plan's reasoning went

* Remove the stray release-metadata patch from the working tree

A 416-line patch file that was applied long ago and has sat in the repository root since. It
predates this branch and stays in the shared history, where rewriting it would mean rewriting
commits that are already on main and on origin.

* Check the translation files in CI and say what they hold

classes already runs the generator, so an orphan key, a dropped placeholder
or a duplicate fails the compile job with the generator's own message naming
the file -- verified by breaking strings_de.properties on purpose.

A step summary counts each language against the base, so the author of a
translation PR sees what they covered without reading the build log.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Refuse a translation key that would not form a Kotlin name

The generator escaped every translation value but emitted the key verbatim as
the member identifier, and identifierFor strips only . _ - -- so a key carrying
a space, a brace, a quote or a newline from a \uXXXX escape broke out of
val <name>: String get() = lookup(...) into an init block or property
initializer that runs when Strings is instantiated. Translation files are the
contribution surface that arrives by pull request, so this was a path from a
merged .properties change to code in every client.

The generated identifier is now held to letters-then-letters-and-digits before
any source is written, alongside the existing orphan and collision refusals.
Proven by replaying a file-writing payload against the built generator: it now
throws and writes nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Port the rebased diagnostics and session logging onto the modules

origin/main landed replayable session logging (MessageHistoryRecorder), file
logging (ApplicationFileLogging) and a user-list refresh split on the old flat
layout. The rebase carried the new files, but three things needed the new
architecture:

- ChatController.fireUserListUpdate() used javafx Platform; core is toolkit-free
  now, so it dispatches through uiDispatcher like every other fire method.
- Two new tests were left in the old src/test/java; moved into core.
- ScoreServiceRefreshTest mocked javafx Platform statically; it now injects the
  DirectUiDispatcher the no-arg constructor installs.

The Leaflet map performance work was dropped with the HTML map it optimised.

classes testClasses and test are green: 1069 tests, 0 failures, 3 skipped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Give the debug-to-file recording a home in the Compose settings

origin/main added a checkbox to the old JavaFX settings that recorded the whole
ON4KST session to file; the Compose redraw dropped the old settings UI, so the
toggle had no control left even though the preference and its wiring survived
the rebase.

It returns to the message-handling tab: the state writes the preference and asks
the application, through a new SettingsHost callback, to open or close the
error-log handler and the history recorder in the order the old checkbox kept.
The explanatory line and its German translation say that passwords are redacted.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Fix Codex review findings on PR 89: station row key, map selection, sort after filter

- Station row key now includes the chat category, so the same callsign in two
  categories no longer collides.
- Map marker click and Reset view go through the central station selection.
- Sorting now operates on the filtered rows, so filters stay effective.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Keep the map drawing test off the network and the user's tile cache

The test assumed no tile ever arrives, but it used the default TileFetcher,
which reads the real disk cache and the OSM tile server. On CI a tile now and
then landed before the frame was rendered and covered the background the
'unreachable tile source' test asserts on. An empty temporary cache and a
source that always fails make the assumption hold by construction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-10-08 23:22:11 +02:00

29 KiB
Raw Blame History

Konzept: In-App-Update für KST4Contest

Status: Konzept, noch nicht umgesetzt. Zielrelease 1.50. Alle Zeilenanker beziehen sich auf nextMajorRelease/version1_50 (Version 1.50.0) und wurden gegen den Branch verifiziert.

Ziel

Stable-Updates werden nach Zustimmung des Nutzers heruntergeladen. KST4Contest beendet sich danach kontrolliert und startet den plattformspezifischen Aktualisierungsvorgang. Updates dürfen den Programmstart nicht blockieren und während eines Contests nicht erzwungen werden.

Ausgangslage

Der vorhandene Mechanismus erfüllt das nicht:

  • UpdateChecker.downloadLatestVersionInfoXML() (src/main/java/kst4contest/controller/UpdateChecker.java:54-71) benutzt new URL(...).openStream() + Files.copy(..., REPLACE_EXISTING) direkt auf die Zieldatei — ohne Timeouts, ohne HTTP-Statusprüfung, ohne temporäre Datei. Ein Fehlschlag beschädigt zusätzlich die lokale Feed-Kopie.
  • Der Aufruf steht synchron im Konstruktor von ChatController (ChatController.java:2937-2941); ChatController wird in Kst4ContestApplication.start(Stage) erzeugt (Kst4ContestApplication.java:6971, start ab :6914). Der Netzwerkaufruf läuft damit unbegrenzt auf dem JavaFX-Application-Thread während des Starts — genau der Punkt „darf den Programmstart nicht blockieren".
  • parseUpdateXMLFile() (UpdateChecker.java:73-236) liest Kindelemente positionsabhängig über einen Zähler in String[7] bzw. String[3] (:144-145, :182-183). Ein achtes Kindelement in <changeLog> erzeugt eine ArrayIndexOutOfBoundsException und killt den gesamten Check.
  • Die Anzeige ist ein eigenes Stage mit setAlwaysOnTop(true) (Kst4ContestApplication.java:9162), inline in start() aufgebaut (:9152-9294) und beim Start automatisch geöffnet (:9280). Es gibt keinen Menüpunkt zum erneuten Prüfen. Ein Catch-All bei :9289-9292 schaltet die Funktion stillschweigend ab, sobald der Feed fehlt oder nicht passt.
  • Toter Code: main() (:27-34) und ein Testdatenblock (:208-234).

Bestätigte Festlegungen

Punkt Entscheidung
Contest-Schutz Hinweis wird unterdrückt, solange eine ON4KST-Verbindung besteht
Update-Starter Kein eigenes Starter-Programm; Installer/Paketverwaltung wird direkt gestartet, danach beendet sich KST4Contest
Flatpak Nur Hinweis mit Update-Befehl, kein Download, kein Artefakt
AppImage Kontrollierter Dateiaustausch, kein AppImageUpdate
Kanal Ausschließlich Stable
Feed-Auslieferung Bleibt wie bisher: der Webserver zieht das Repo alle 5 Minuten per Git und baut die Website selbst
Zuschnitt Drei Stufen
Signatur SignPath Foundation, als optionaler additiver CI-Schritt; unsigniert bleibt lauffähig
Windows-ZIP Bleibt als portable Alternative

Was unverändert bleibt

  1. Alte Clients (≤ 1.44) am erweiterten Feed. UpdateChecker sucht per getElementsByTagName nach latestVersion, versionNumber, semanticVersion, adminMessage, majorChanges, latestVersionPathOnWebserver, changeLog, bug. Das ist eine Descendant-Suche — deshalb kommt der neue Block als Geschwister neben <latestVersion> und benutzt ausschließlich neue Elementnamen.
  2. <changeLog> behält exakt seine 7 Kinder (changedVersionNumber, date, description, added, changed, fixed, removed) in unveränderter Reihenfolge, <bug> seine Struktur. <needUpdateSinceLastVersion>, <roadmap>, <bugsReported> bleiben unangetastet.
  3. ~/.praktiKST/ — nur ein neues Unterverzeichnis updates/. kst4ContestVersionInfo.xml behält Name und Ort, damit ein Downgrade auf 1.44 funktioniert.
  4. Windows-ZIP als Portable — die App verändert ihr eigenes Verzeichnis nie und führt für diesen Typ keinen Installer aus.
  5. Kein Eingriff in Flatpak-, AUR-, DEB-, RPM- oder Arch-Installationen; kein sudo/pkexec aus der Anwendung heraus.
  6. Offlinebetrieb — ein fehlgeschlagener Check ist stumm (nur java.util.logging), der Programmstart ist davon vollständig entkoppelt.
  7. Legacy-Vergleich — APPLICATION_CURRENTVERSIONNUMBER und <versionNumber> bleiben als Fallback; VersionUtils.compareStableVersions wird wiederverwendet und nicht verändert.
  8. Bei unbekannter Installationsart wird ausschließlich die Downloadseite geöffnet.

Stufe 1 — Feed, Paketkennzeichnung, Prüfdienst, Hinweis-UI

Kein Download, kein Installationsstart.

1a. Installationsart zur Buildzeit kennzeichnen

Es existiert heute keinerlei Build-Metadatum: kein --java-options, keine .properties unter src, kein Resource-Filtering in pom.xml, keine Manifest-Einträge.

Gewählter Mechanismus: jpackage-Flag --java-options -Dkst4contest.packageType=<typ>.

Alternative Warum nicht
Gefilterte .properties-Resource Alle Pakettypen entstehen aus demselben Maven-Artefakt; die Unterscheidung fällt erst im jpackage-Aufruf. Lokale Builds und Tests bekämen einen falschen Marker.
Manifest-Eintrag Gleiches JAR-Problem, mehr Bewegungsteile.
Verzeichnis-/Prozessheuristik Laut Zielbild ausdrücklich ausgeschlossen; bei ZIP-Portable ohnehin frei verschiebbar.
Reines Env-Sniffing Erkennt Flatpak und AppImage, aber nicht deb/rpm/arch/zip/msi.

Vorteile: keine Auswirkung auf mvn/Tests/lokale Entwicklung (Property fehlt → UNKNOWN → sicherer Fallback); der Wert landet in lib/app/<Name>.cfg des app-image und wird dadurch vom AUR--bin-Repack (packaging/aur/kst4contest-bin/PKGBUILD macht nur cp -a usr) und vom Flatpak-Build (bindet das app-image als type: dir-Source ein) automatisch mitkopiert.

Werte: windows-zip, windows-msi, macos-dmg, linux-appimage, flatpak, linux-deb, linux-rpm, linux-arch.

15 Aufrufstellen:

Datei Zeilen Wert
.github/workflows/tagged-release.yml 53 / 104 / 184 / 238 / 292 / 403 windows-zip / linux-appimage / linux-deb / linux-rpm / linux-arch / flatpak
.github/workflows/nightly-artifacts.yml 69 / 127 / 214 / 275 / 338 / 458 dieselbe Reihenfolge
packaging/macos/build-signed-dmg.sh 72 macos-dmg
packaging/aur/kst4contest/PKGBUILD 44 linux-arch
packaging/aur/kst4contest-git/PKGBUILD 37 linux-arch

packaging/aur/kst4contest-bin/PKGBUILD erbt korrekt — keine Änderung.

PowerShell-Syntax (tagged-release:53, nightly:69) braucht einfache Anführungszeichen, sonst frisst PowerShell das -D: --java-options '-Dkst4contest.packageType=windows-zip'

Auflösung zur Laufzeit (RuntimePackageTypeResolver), bewusst konservativ:

  1. System.getProperty("kst4contest.packageType"); unbekannter Wert → weiter.
  2. /.flatpak-info vorhanden oder FLATPAK_ID gesetzt → FLATPAK. Diese Prüfung überschreibt die Property — eine Fehlklassifikation richtet ausgerechnet im Flatpak den größten Schaden an (Download in eine Sandbox, die den Host nie aktualisieren kann).
  3. APPIMAGE gesetzt → LINUX_APPIMAGE.
  4. sonst UNKNOWN.

1b. Feed erweitern

Der Feed wird von der Website erzeugt (website/src/_data/versionInfo.js, ausgeliefert über website/src/version-info.njk), gespeist aus der GitHub-Releases-API — nicht aus den Build-Jobs. Der Webserver zieht das Repository alle 5 Minuten per Git und baut selbst; eine geänderte versionInfo.js wird dadurch automatisch wirksam, ohne Upload-Schritt in den Workflows.

Platzierung: neues Top-Level-Element als Geschwister von <latestVersion>. Ein Kindelement innerhalb <latestVersion> wäre riskant, weil der alte Parser dort per Descendant-Suche liest; als Geschwister ist jede Kollision strukturell ausgeschlossen.

<updatePackages formatVersion="1" semanticVersion="1.45.0">
    <updatePackage>
        <packageType>linux-deb</packageType>
        <operatingSystem>linux</operatingSystem>
        <architecture>x86_64</architecture>
        <fileName>KST4Contest-v1.45.0-debian-amd64.deb</fileName>
        <downloadUrl>https://github.com/praktimarc/kst4contest/releases/download/v1.45.0/…</downloadUrl>
        <fileSizeBytes>142335488</fileSizeBytes>
        <sha256>9f2c…</sha256>                      <!-- 64 hex, klein -->
        <signatureState>unsigned</signatureState>    <!-- unsigned | authenticode | apple-notarized | gpg-repo -->
        <releaseNotesUrl>…/releases/tag/v1.45.0</releaseNotesUrl>
        <installHint>package-manager</installHint>   <!-- run | package-manager | portable | hint-only -->
    </updatePackage>
    <updatePackage>
        <packageType>flatpak</packageType>
        <operatingSystem>linux</operatingSystem>
        <architecture>x86_64</architecture>
        <signatureState>gpg-repo</signatureState>
        <releaseNotesUrl>…/releases/tag/v1.45.0</releaseNotesUrl>
        <installHint>hint-only</installHint>
        <hintCommand>flatpak update de.x08.KST4Contest</hintCommand>
        <!-- bewusst ohne downloadUrl/sha256 -->
    </updatePackage>
</updatePackages>

Datenherkunft in versionInfo.js:

  • fileName, downloadUrl, fileSizeBytes stehen bereits in der vorhandenen /releases-Antwort (release.assets[] mit name, browser_download_url, size) — kein zusätzlicher API-Aufruf. Aktuell werden die Assets weggeworfen.
  • packageType/operatingSystem/architecture über einen deterministischen Klassifikator auf die Assetnamen, die die Workflows fest vergeben (tagged-release.yml:783-791): -windows-x64.zip, -linux-x86_64.AppImage, -debian-amd64.deb, -fedora-x86_64.rpm, -archlinux-*.pkg.tar.zst, -macos-*.dmg. .flatpakref erzeugt keinen Download, sondern den synthetischen Hint-Eintrag. Manuals und der Feed selbst werden übersprungen.
  • sha256 muss der Release-Workflow erzeugen. Im Job release-tag liegen alle Artefakte bereits unter release-assets/*, bevor ncipollo/release-action läuft. Dort nach den download-artifact-Schritten und vor „Create tagged release": 
    - name: Compute release asset checksums
  run: |
    cd release-assets
    find . -type f ! -name SHA256SUMS.txt -print0 \
      | xargs -0 sha256sum | sed 's#\./##' > SHA256SUMS.txt
    und release-assets/SHA256SUMS.txt in die artifacts:-Liste (:783-791) aufnehmen. Die bestehende Reihenfolge (Release zuerst, dann Website-Build, :771-825) bleibt korrekt — die Summen liegen zum Zeitpunkt des Website-Builds bereits am Release. versionInfo.js lädt die Datei nur für das neueste Stable-Release und baut daraus eine filename → sha256-Map; das ist ein Download-URL-Abruf und belastet das API-Ratelimit nicht.
  • signatureState aus einer statischen Tabelle je packageType (macos-dmg → apple-notarized, flatpak → gpg-repo, Rest unsigned). In Stufe 3 wird windows-msi nur dann auf authenticode gesetzt, wenn ein signiertes Asset tatsächlich existiert — der Feed darf nicht lügen, wenn der SignPath-Schritt übersprungen wurde.

Robustheit: Weil der Server unabhängig vom Release-Workflow baut, kann er einen Feed erzeugen, bevor SHA256SUMS.txt am Release hängt. Fehlt <sha256>, gilt das Artefakt als nicht automatisch ladbar — der Client öffnet nur die Downloadseite. Ein Artefakt ohne Prüfsumme wird nie geladen und nie gestartet. Die bestehende try/catch-Klammer in versionInfo.js bricht den Website-Build bei einem unvollständigen Feed ab; die neue Sektion darf nicht so scharf sein — bei Problemen wird <updatePackages> weggelassen, der Rest des Feeds bleibt gültig.

Mitzuziehen:

  • website/scripts/validate-version-info.js — bekannter packageType; sha256 matcht ^[0-9a-f]{64}$; downloadUrl beginnt mit https://github.com/praktimarc/kst4contest/releases/download/; fileSizeBytes numerisch > 0. Zusätzlich neu und wichtig: <changeLog> muss weiterhin exakt die 7 Kinder in der Altreihenfolge haben — das nagelt die Alt-Client-Kompatibilität fest.
  • website/test/version-info.test.js — Klassifikator, SHA256SUMS-Parsing, „Release ohne Assets".

Warnung, nicht Teil dieser Umsetzung: .github/workflows/test-publish-version-xml.yml (ungetrackt, nur workflow_dispatch) erzeugt mit einem eigenen Python-Generator einen konkurrierenden Feed ohne <semanticVersion> und lädt ihn per WebDAV hoch. Würde er ausgelöst, fielen alle Clients auf den kaputten Double-Vergleich (1.41.1 → 1.411) zurück.

1c. Prüfdienst neu bauen

Neues Package kst4contest.service.update (konsistent zum vorhandenen kst4contest/service/path/).

Datei Verantwortung
model/PackageType.java Enum + feedId(), fromFeedId() (null/unbekannt → UNKNOWN, wirft nie), updateStrategy()
model/UpdatePackageInfo.java Transport-DTO, explizite Klasse, kein Record (AGENTS.md)
model/UpdateCheckResult.java Ergebnis-DTO inkl. resultSource (NETWORK/CACHE/NONE)
service/update/UpdateFeedParser.java Reiner Parser, kein IO, kein Netz
service/update/UpdateFeedClient.java Nur HTTP, injizierbarer HttpClient + Timeouts
service/update/UpdateCheckService.java Orchestrierung, injizierbare Abhängigkeiten + Clock
service/update/RuntimePackageTypeResolver.java Installationsart, Test-Konstruktor für Property/Env/Pfad

Muster: OpenMeteoTerrainProfileProvider.java:76-88 (injizierbarer Client, konfigurierbare Timeouts), TerrainPackageDownloader.java:107-145 (Temp-Datei → Statusprüfung → Files.move).

Verhalten:

  • Aufruf asynchron im Daemon-Thread, erst nach primaryStage.show() — nie vorher. ChatController.java:2937-2941 entfällt.
  • Ergebnis über eine ObjectProperty<UpdateCheckResult> im ChatController, gesetzt via Platform.runLater. Muster: lastUiReminderEvent (ChatController.java:4236-4243). Der Worker fasst keine ObservableList an.
  • Versionsvergleich über VersionUtils.compareStableVersions. Achtung: parseVersion wirft bei leerem oder nicht-numerischem Input (IllegalArgumentException/NumberFormatException) — der Dienst muss das fangen und auf den Double-Pfad zurückfallen. Heute ist das in der View (:9266-9278) nicht abgesichert.
  • Ausschließlich Stable. Fehlende Verbindung erzeugt keine Meldung, nur einen Logeintrag über java.util.logging statt System.out. Höchstens eine Meldung je Sitzung. Bei Netzfehler Rückfall auf die zuvor gecachte Datei.

Positionales Parsing entschärfen: Primärpfad namensbasiert (readChildText(element, "changedVersionNumber") …), Ergebnis weiterhin als String[7] in derselben Reihenfolge, damit der TreeView-Aufbau im Update-Fenster unverändert bleibt. Kompatibilitätspfad für uralte Feeds behält den positionalen Walk, aber mit if (counter >= entry.length) break;. Präfixe ("Date: ", "Desc: ") exakt erhalten. Bei <bug> ist aChangeLogEntry[2] heute uninitialisiert → explizit "".

UpdateChecker.java wird durch den Dienst ersetzt.

1d. Hinweis-UI

Wiederverwendet wird das etablierte Muster initSkedWarnIndicatorButton() (Kst4ContestApplication.java:5790-5807) und initBandUpgradeIndicatorButton() (:5965): versteckt per Default, managedProperty().bind(visibleProperty()), eingehängt in flwpne_StatusBar (Aufbau :7158, setTop :7161, Indicator-Buttons :7163, :7166, :7189).

Abweichung: nicht setMouseTransparent(true) — der Button ist klickbar und öffnet ein ContextMenu.

  • Text: KST4Contest 1.x.y is available
  • Aktionen: Änderungen anzeigen · Update herunterladen (Stufe 1: deaktiviert bzw. „Release-Seite öffnen") · für diese Sitzung schließen
  • Contest-Regel: visible = updateAvailable && !dismissedForSession && Verbindungszustand != ONLINE. onConnectionStateChanged(...) (:12566) ruft zusätzlich refreshUpdateHintVisibility() im vorhandenen Platform.runLater-Block — der Hinweis verschwindet beim Login in den Chat und kommt beim Trennen zurück.
  • FX-Thread-Guard-Idiom aus :5833 übernehmen.
  • Neuer Menüpunkt im Info-Menü (Info-Menü, helpMenu.getItems().addAll(...) :5774): „Check for updates…" und „Show update details…". Damit existiert erstmals ein manueller Re-Check.
  • Das bestehende stage_updateStage wird aus start() in eine eigene, lazy aufgerufene Methode herausgezogen; gespeicherte Fenstergröße (getGUIstage_updateStage_SceneSizeHW, :9253-9260) bleibt. Das Auto-show() (:9280) entfällt, setAlwaysOnTop(true) (:9162) wird entfernt — ein Always-on-Top-Fenster über einem laufenden Contest ist genau das, was das Ziel verbietet.

1e. Versionsdrift absichern

pom.xml:9 und ApplicationConstants.APPLICATION_CURRENT_VERSION werden von Hand gepflegt, ohne jede Prüfung. Für einen Mechanismus, der genau diese Zeichenkette vergleicht, ist das die riskanteste Stelle. Analog zu packaging/AddModules.java --verify-pom (an validate gebunden, pom.xml:219-240) einen --verify-version-Wächter ergänzen. Kein Auto-Bump.

docs/PROJECT_CONTEXT.md:198 beschreibt zusätzlich die Kodierung von APPLICATION_CURRENTVERSIONNUMBER (1.43.1 → 1.431) — beim Bump mitführen, solange das Legacy-Feld existiert. Auf 1.50 stehen die Werte in ApplicationConstants.java:23 und :30.

1f. --app-version nachziehen

Außer im macOS-Skript (build-signed-dmg.sh:75) setzt kein jpackage-Aufruf --app-version. DEB und RPM tragen dadurch intern die Vorgabeversion 1.0; ein apt install ./KST4Contest-v1.45.0.deb wäre für dpkg kein Upgrade. Vor Stufe 3 zwingend, sinnvollerweise überall — dieselbe sed-Ableitung wie build-signed-dmg.sh:59-65. Nebenwirkung: bestehende DEB/RPM-Installationen springen einmalig von 1.0 auf die echte Version.

Stufe 2 — Gesicherter Download

Erst nach „Update herunterladen".

Datei Verantwortung
service/update/UpdateDownloadPolicy.java Reine Validierung, kein IO
service/update/UpdateDownloadService.java Download + Verifikation
service/update/UpdateStorage.java ~/.praktiKST/updates/, Aufräumen verwaister Dateien
model/UpdateDownloadResult.java Ergebnis-DTO

Ablauf (Muster TerrainPackageDownloader.java:93-165):

  1. Download nach <fileName>.download;
  2. Prüfung von Dateigröße und SHA-256 (computeSha256, :175-187, 8-KiB-Puffer + HexFormat);
  3. Files.move erst nach erfolgreicher Prüfung;
  4. bei Abbruch oder falscher Prüfsumme temporäre Datei löschen, verständliche Meldung;
  5. niemals ein ungeprüftes Artefakt starten.

Empfehlung: BodyHandlers.ofInputStream() + DigestInputStream statt ofFile — ein Durchlauf statt zwei, und ein Fortschrittsbalken ist bei 150-MB-Dateien Pflicht. Short-circuit, wenn die Zieldatei bereits mit passendem Hash existiert.

Sicherheitsschranke — nicht optional: SHA-256 aus dem Feed beweist nur, dass die Datei zum Feed passt. Da der Feed über einen selbst gebauten Host ausgeliefert wird, ist eine Host-Allowlist (github.com, objects.githubusercontent.com) die eigentliche Schutzschicht: selbst ein manipulierter Feed kann keine beliebige URL unterschieben. UpdateDownloadPolicy prüft zusätzlich: Schema https; sha256 matcht ^[0-9a-fA-F]{64}$; fileName ohne /, \, ..; fileSizeBytes > 0 und < 1 GiB; ausreichend Plattenplatz; packageType erlaubt Download.

Stufe 2 führt nichts aus. Nach Erfolg: „Jetzt beenden und aktualisieren" / „Später installieren". Flatpak erhält gar keinen Download-Pfad, sondern den Hinweistext aus <hintCommand>.

Stufe 3 — Plattformausführung, Windows-Installer, Signatur

3a. Windows-Installer

--type msi mit dauerhaft konstanter --win-upgrade-uuid, dazu --win-menu --win-shortcut --win-dir-chooser. choco install wixtoolset steht bereits in beiden Workflows (tagged-release.yml:33-35, nightly-artifacts.yml:49-51) und wird bisher nicht genutzt — die Voraussetzung ist vorhanden. Der ZIP-Build bleibt bestehen.

Die GUID muss dokumentiert werden (z. B. packaging/windows/README.md) — ändert sie sich, sind MSI-Upgrades dauerhaft kaputt. Asset in die artifacts:-Liste und in den SHA256SUMS-Schritt aufnehmen.

3b. Ausführung je Installationsart

Installation Verhalten
windows-msi msiexec /i "<datei>" /qb detached, danach beenden
windows-zip Keine Ausführung. Installer laden, Ordner öffnen, Benutzerdaten bleiben. Hinweis nötig, dass der alte ZIP-Ordner bestehen bleibt und künftig der Installer-Eintrag zu starten ist — sonst startet der Nutzer weiter die alte praktiKST.exe und sieht nie wieder ein Update
macos-dmg open "<dmg>", danach beenden; der Nutzer zieht selbst. Ein laufendes .app kann sich ohne separates Updater-Binary nicht ersetzen
linux-appimage Neues AppImage neben $APPIMAGE ablegen, chmod +x, Ordner öffnen, beenden. Kein In-Place-Overwrite einer laufenden Datei
flatpak Nur Verweis auf flatpak update de.x08.KST4Contest; keine Datei im Paket anfassen
linux-deb/rpm/arch xdg-open "<datei>" → GNOME Software / Discover / gdebi übernehmen inkl. Rechteabfrage. Bewusst kein pkexec/sudo aus der Anwendung heraus
AUR Verweis auf den vorhandenen AUR-Helper
UNKNOWN Ausschließlich Downloadseite öffnen

Kein eigener Update-Starter. Der kontrollierte Ausstieg: Verbindung prüfen und ggf. bestätigen lassen → ON4KST sauber trennen → Layout/Preferences flushen → DB schließen → Installer starten → Platform.exit() + System.exit(0). Kein Runtime.halt. Der vorhandene Weg über Kst4ContestApplication.stop() (disconnect("CLOSEALL") + System.exit(0)) bleibt die Basis.

3c. SignPath

Eigener Step im MSI-Job, gegated über das Vorhandensein des Secrets. Fehlt es (bis zur Foundation-Freigabe), läuft die Pipeline unverändert durch und liefert ein unsigniertes MSI. Signiertes Ergebnis unter eigenem Namen hochladen; versionInfo.js setzt signatureState nur, wenn dieses Asset existiert.

Vorbedingung für die Abhängigkeitsprüfung: module-info.java:14-15 deklariert requires org.junit.jupiter.api; und requires org.mockito;, weil Testklassen unter src/main/java/ liegen (u. a. controller/On4KstProtocolTest.java, controller/On4KstSocketThreadTest.java, controller/ReadUDPByWintestThreadTest.java, test/MockKstServer.java, view/map/mapTest.java). pom.xml deklariert junit-jupiter-api und mockito-core deshalb mit <scope>compile</scope>, und JUnit, Mockito, ByteBuddy und Objenesis landen im ausgelieferten Runtime-Image — im Flatpak in lib/app/ nachgewiesen. Ausgerechnet ByteBuddy/Mockito (Bytecode-Manipulation, Agent) in einem signierten Produktionsbinary ist für so eine Prüfung ungünstig. Als eigener, abgegrenzter Commit vor dem Antrag bereinigen: Klassen nach src/test/java/, requires entfernen, Scopes zurück auf test.

Tests

Alle neuen Tests unter src/test/java/kst4contest/service/update/ bzw. .../model/, Fixtures unter src/test/resources/update/. Nichts Neues unter src/main/java — die dort liegenden Testklassen sind Altlast, keine Vorlage.

Testklasse Assertions
UpdateFeedParserTest Legacy-Feed 1.44 ohne <updatePackages> parst korrekt; erweiterter Feed, Reihenfolge irrelevant; <changeLog> mit 8 Kindern → keine ArrayIndexOutOfBoundsException; kaputtes XML → leeres Ergebnis statt Exception; XXE-Payload wird nicht expandiert; sha256 in Großbuchstaben wird normalisiert
UpdateFeedClientTest 200 → Zieldatei ersetzt; 404/500 → Temp gelöscht und vorhandene Zieldatei unverändert (die konkrete Regression gegenüber UpdateChecker:54-71); Timeout → success=false, kein Throw; leerer Body verworfen
UpdateCheckServiceTest 1.44.0/1.44.0 → kein Update; /1.45.0 → Update; /1.4.4 → kein Update; /1.44.1 → Update; kaputte semanticVersion → Double-Fallback statt Exception; Netz down + Cache → CACHE; ohne Cache → NONE; Paketauswahl je Typ; UNKNOWN → kein Paket; injizierte Clock für den Prüfrhythmus
RuntimePackageTypeResolverTest Property gewinnt; unbekannter Wert → UNKNOWN; /.flatpak-info → FLATPAK auch gegen widersprechende Property; APPIMAGE → AppImage; alles null → kein NPE
UpdateDownloadPolicyTest http:// abgelehnt; fremder Host abgelehnt; fehlende/zu kurze/nicht-hex sha256 abgelehnt; fileName mit ../ abgelehnt; Größe ≤ 0 abgelehnt; FLATPAK/UNKNOWN abgelehnt
UpdateDownloadServiceTest Ohne Netz über com.sun.net.httpserver.HttpServer auf Port 0 (JDK-only, keine neue Dependency): Hash-Mismatch → Temp gelöscht, Ziel nicht angelegt; Match → Bytes identisch; Non-2xx → Temp gelöscht; bereits gültige Datei → kein HTTP-Call; Progress monoton bis totalBytes; Abbruch → Temp gelöscht
UpdateLauncher*Test (Stufe 3) Injizierter ProcessStarter fängt die Kommandozeile: MSI → [msiexec, /i, <abs>, /qb]; deb/rpm/arch → [xdg-open, <abs>]; dmg → [open, <abs>]; kein Kommando enthält sudo oder pkexec (explizite Assertion); FLATPAK/UNKNOWN/WINDOWS_ZIP → ProcessStarter nie aufgerufen
website/test/version-info.test.js Klassifikator für alle Namensmuster; SHA256SUMS-Parsing inkl. Doppelspace; Release ohne Assets → Feed bleibt valide; erzeugter Feed hat weiterhin exakt 7 <changeLog>-Kinder

Versionsvergleich: bestehende VersionUtils-Abdeckung um nicht-numerische Eingaben ergänzen.

Dokumentation

Nach jeder Stufe eine gezielte Einordnung, kein Voll-Audit (AGENTS.md):

  • github_docs/de-Installation.md und github_docs/en-Installation.md — Windows-Installer, Verhältnis zum ZIP, Update-Weg je Paketformat, Flatpak-Hinweis. Beide Sprachversionen semantisch gleichziehen.
  • Neuer Abschnitt zur Updatefunktion (Hinweis, Zustimmung, Contest-Regel, Verhalten je Installationsart) — DE und EN.
  • docs/PROJECT_CONTEXT.md — Abschnitt „Website / Deployment Relationship" (:192-200) um Feed-Format, Paketkennzeichnung, Host-Allowlist und die Entscheidung gegen ein Updater-Binary ergänzen.
  • website/src/features/ prüfen, ob die Funktion dort dargestellt werden soll.
  • Screenshots des Hauptfensters veralten durch den Hinweisbereich — als veraltet markieren, nicht erfinden.

Verifikation

  1. ./mvnw -B test — Surefire-Berichte einzeln lesen, nicht am Exit-Code messen (AGENTS.md: Testfehler brechen den Build nicht ab). Hinweis: auf Host-JDK 26 schlagen 8 Mockito-Tests umgebungsbedingt fehl; mit Temurin 21 prüfen.
  2. cd website && npm test && npm run build && npm run validate:version-info gegen einen erweiterten Beispiel-Feed.
  3. Abwärtskompatibilität: erweiterten Feed gegen den alten UpdateChecker laufen lassen und bestätigen, dass <latestVersion> und <changeLog> unverändert gelesen werden.
  4. Startverhalten: Anwendung mit nicht erreichbarer Feed-URL starten — die UI muss ohne Verzögerung und ohne Meldung hochkommen.
  5. Contest-Regel: mit ON4KST verbunden erscheint kein Hinweis; nach dem Trennen erscheint er.
  6. Paketkennzeichnung: je Artefakt einmal starten und die erkannte Installationsart prüfen. Der Flatpak lässt sich lokal testen — die Sandbox ist netzwerkseitig transparent (verifiziert).
  7. Stufe 2: Download mit absichtlich falscher Prüfsumme — es darf keine Zieldatei entstehen und nichts gestartet werden.

Offene Punkte

  1. Zweite Feed-Quelle? Wenn der serverseitige Build hinterherhinkt, sehen Clients einen veralteten Feed. Soll der Client hilfsweise https://github.com/praktimarc/kst4contest/releases/latest/download/kst4ContestVersionInfo.xml verwenden?
  2. test-publish-version-xml.yml bleibt vorerst unverändert, ist aber scharf (Feed ohne <semanticVersion>). Bei der späteren Umstellung auf GitHub Actions zusammenführen oder entfernen.
  3. --app-version überall setzen ändert die Paketversion bestehender DEB/RPM-Installationen einmalig von 1.0 auf die echte. Akzeptabel?
  4. UpdateChecker.java löschen oder als deprecated Fassade behalten? (module-info.java exportiert kst4contest.controller.)
  5. MSI vs. ZIP — soll MSI der empfohlene Windows-Weg werden? Beide Installationen können parallel existieren; ein MSI-Upgrade findet eine ZIP-Installation nicht.
  6. Opt-out-Preference? Soll ChatPreferences ein „Check for updates on start" bekommen? Der Abruf verrät IP und Version an den Feed-Host.
  7. Prüfrhythmus — einmal pro Start, oder höchstens alle 24 h über einen Zeitstempel in ~/.praktiKST/?
  8. Beta-Nutzer — 1.46.0-beta gegen Stable 1.45.0 ergibt „kein Update", weil compareStableVersions das Suffix abschneidet. Gewollt?
  9. Signaturzustand darf nur automatisch aus dem Build stammen, sonst driftet er.
  10. Vertrauensmodell — soll der Feed mittelfristig selbst signiert werden (Detached-Signatur + eingebauter Public Key)?
  11. ZIP-Migration — der Hinweistext für den Wechsel ZIP → Installer muss formuliert und in beiden Sprachversionen dokumentiert werden.
Reference in new issue View Git Blame Copy Permalink